Skip to content

7.0.8 Rebase #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Jul 10, 2023
Merged

7.0.8 Rebase #2

merged 0 commits into from
Jul 10, 2023

Conversation

@13r0ck
Copy link
Contributor

@13r0ck 13r0ck commented Apr 25, 2023 •
edited
Loading

@13r0ck 13r0ck requested review from a team April 25, 2023 16:13
This was referenced Apr 25, 2023
Closed
Closed
Closed
@mmstick mmstick mentioned this pull request Jul 7, 2023
Merged
XV-02
XV-02 previously approved these changes Jul 7, 2023
View reviewed changes
@XV-02 XV-02 dismissed their stale review July 7, 2023 20:54

Forgot to look at Ubuntu

@XV-02
Copy link

XV-02 commented Jul 7, 2023

This PR for virtualbox-ext-pack largely works. There is an arguement that a post install script should add the user to the vboxusers group, as that's required for USB pass-through to actually function.

However, we probably also need this for Ubuntu. I am happy to approve if it's felt that a push to Ubuntu is not needed.

@jackpot51
Copy link
Member

jackpot51 commented Jul 10, 2023

I have made it so this will build for Ubuntu.

XV-02
XV-02 approved these changes Jul 10, 2023
View reviewed changes
Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working on Ubuntu 22.04 and Pop 22.04 in concert with updated Virtualbox. Good to go.

@mmstick mmstick merged commit f16f82d into master_jammy Jul 10, 2023
@mmstick mmstick deleted the linux-6.3_jammy branch July 10, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

+1 more reviewer

@XV-02 XV-02 XV-02 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@13r0ck @XV-02 @jackpot51 @mmstick