Do not enable GeoIP serverwide by default + recommend geoip-database #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not recommended by MaxMind and also not logical: a server may have many vhosts and only a small subset of hosts or paths may actually need the GeoIP information in the request. Therefore, it's much better to enable it selectively for those vhosts/locations/directories where it will actually be used.
When you install mod-geoip, you likely also want a database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module installs a file geoip.conf in mods-available, which by default
enables GeoIP lookups serverwide; that is, for every request to this server
a GeoIP database lookup will be done.
This is not recommended by MaxMind and also not logical: a server may have
many vhosts and only a small subset of hosts or paths may actually need
the GeoIP information in the request. Therefore, it's much better to
enable it selectively for those vhosts/locations/directories where it
will actually be used.
Also, recommend geoip-database.