Skip to content

Conversation

@rschristian
Copy link
Member

Bit silly but I think it's necessary as a kickstart for the v10.x benches.

Specifically, the benches currently fail after trying to move the artifact that's meant to be downloaded by andrewiggins/download-base-artifact:

Trying to get workflow matching "ci.yml"...
Resolved to "CI" (id: 722041)
Base ref of pull request is v10.x
Base commit of pull request is 0be5d206ec8ac309d47b780604c3023e23dbe09b
Warning: Workflow run for 0be5d206ec8ac309d47b780604c3023e23dbe09b (CI#5117) was not successful. Conclusion was "failure". Could not find any successful workflow run for v10.x to fall back to.
Error was thrown but "required" input is set to false so ignoring it. See below for error.
Error: Could not find workflow run matching {"workflowId":722041,"baseCommit":"0be5d206ec8ac309d47b780604c3023e23dbe09b","baseRef":"v10.x","status":"success"}

Source

I think we just need a dummy successful run here to kickstart things as there's no setting in that action to download from failed runs and we can't have a successful run without bailing out entirely.

I wasn't quite sure if exit 0 would bail out of the benches too, or if they'd then fail as there was no artifact, so I just commented them out. Obviously we'll revert this once we have a successful run to consume in subsequent runs.

@preactjs preactjs deleted a comment from github-actions bot Aug 31, 2025
@rschristian rschristian merged commit 3e86d02 into v10.x Sep 1, 2025
4 checks passed
@rschristian rschristian deleted the ci/fix-benches-v10 branch September 1, 2025 19:19
rschristian added a commit that referenced this pull request Sep 1, 2025
rschristian added a commit that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants