only break import deconstruction if the list of items is longer than 1 #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
approved these changes
Jul 9, 2025
Member
fvictorio
left a comment
fvictorio
left a comment
There was a problem hiding this comment.
I was on the fence about this change, but apparently Prettier core does the same, so yeah, let's do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by looking at openzeppelin's long imports I noticed that forcing to break a single deconstructed import into multiple lines, only makes the file longer and the most important part is the imported object.
This makes files with multiple imports where some of them break and some don't a bit confusing to read. That's why I think we could review the import rule so only deconstructions longer than one item will break.
This will force the
openzeppelin-contractspackage to re-write some of the contracts that were just updated when they upgraded to[email protected]because of this reason, which is undesirable but I believe is an important tweak.