Skip to content

Conversation

@fvictorio
Copy link
Member

contract Contract {                                                                                                             
   bytes32 private constant DOMAIN_SEPARATOR_TYPEHASH = 0x035aff83d86937d35b32e04f0ddc6ff469290eef2f1b692d8a815c89404d4749;      
 }

becomes

contract Contract {                                                                                                             
     bytes32 private constant DOMAIN_SEPARATOR_TYPEHASH =                                                                        
         0x035aff83d86937d35b32e04f0ddc6ff469290eef2f1b692d8a815c89404d4749;                                                     
 }

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #388 (0aba31c) into master (e7ea8ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          90       90           
  Lines         722      726    +4     
  Branches      138      139    +1     
=======================================
+ Hits          720      724    +4     
  Misses          2        2           
Impacted Files Coverage Δ
src/nodes/StateVariableDeclaration.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ea8ef...aee4f51. Read the comment docs.

@fvictorio
Copy link
Member Author

@mattiaerre can we remove the codecov integration? It's way more annoying than useful.

@fvictorio fvictorio force-pushed the long-state-variable-declarations branch from 5c37ae5 to aee4f51 Compare November 10, 2020 12:21
Copy link
Member

@mattiaerre mattiaerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@mattiaerre mattiaerre merged commit fae74c7 into master Nov 12, 2020
@mattiaerre mattiaerre deleted the long-state-variable-declarations branch November 12, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants