Don't join multi-part literals #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 90 90
Lines 731 736 +5
Branches 140 140
=======================================
+ Hits 729 734 +5
Misses 2 2
Continue to review full report at Codecov.
|
mattiaerre
approved these changes
Nov 19, 2020
Comment on lines
+15
to
+28
| contract MultipartStrings { | ||
| bytes b1 = hex"beef"; | ||
| bytes b2 = hex"beef"; | ||
| bytes b3 = hex"beef" hex"c0ffee"; | ||
| bytes b4 = | ||
| hex"beeeeeeeeeeeeeeeeeeeeeef" | ||
| hex"c0000000000ffeeeeeeeeeeeeeeeeeee"; | ||
|
|
||
| string s1 = "foo"; | ||
| string s2 = "foo" "bar"; | ||
| string s3 = | ||
| "foofoofoofooofoofoofofoooofofoo" | ||
| "barbarbrabrbarbarbabrabrbabr"; | ||
| } |
|
LGTM!!! Can't wait to clean up some contracts! |
|
Also in semi-related issues to allow for multiline hex literals output by this new formatter: |
Member
Author
|
@junderw they just need to update the parser to the latest version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
This PR prevents prettier from joining multi-part strings and hex literals. It also prints each one in a separate line when the line is too long.