ActionList: Fix multiple selection svg by overriding global shape-rendering for github.com #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c2fd500 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
changed the title
size-limit report 📦
|
colebemis
approved these changes
Nov 30, 2021
Merged
pksjce
pushed a commit
that referenced
this pull request
Dec 20, 2021
…dering for github.com (#1668) * override global shape-rendering for github.com * add changelog * add issue to comment * update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1666
There is a global declaration in
gitproxy.zycloud.tkin commit-acitivity.scss#L17 which makes the multi-selection look strange:The ideal fix would be to remove the global style declaration but that's not going to a trivial task as this line is pretty old with implicit dependencies across the codebase.
We can absorb this override into the component as a workaround. Hopefully we can remove this in the future.
Screenshots
Before:
After:
Merge checklist