Skip to content

Conversation

@colebemis
Copy link
Contributor

@colebemis colebemis commented Dec 4, 2021

Part of #1701

Previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2021

⚠️ No Changeset found

Latest commit: 7e8735a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 57.25 KB (0%)
dist/browser.umd.js 57.6 KB (0%)

@colebemis colebemis changed the title Update component docs Update component docs (Link, TextInput, ActionList2) Dec 6, 2021
@colebemis colebemis added the skip changeset This change does not need a changelog label Dec 6, 2021
@colebemis colebemis marked this pull request as ready for review December 6, 2021 20:23
@colebemis colebemis requested review from a team and rezrah December 6, 2021 20:23
Copy link
Contributor

@jfuchs jfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm liking this 😻

<Box as="td" colSpan={4} fontSize={1} verticalAlign="top" fontStyle="italic">
Additional props are passed through to the <InlineCode>&lt;{elementName}&gt;</InlineCode> element. See{' '}
<Box as="td" colSpan={4} fontSize={1} verticalAlign="top">
Additional props are passed to the <InlineCode>&lt;{elementName}&gt;</InlineCode> element. See{' '}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding something like a ⚠️ to call out this row?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure. ⚠️ makes me think is a "bad" thing but I'm not sure it is 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fair. 👍🏻


## Related components

- [ActionMenu](/drafts/ActionMenu2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this "ActionMenu2" in the link text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave that up to @siddharthkp

@colebemis colebemis merged commit 852f5e1 into main Dec 6, 2021
@colebemis colebemis deleted the update-component-docs branch December 6, 2021 21:33
pksjce pushed a commit that referenced this pull request Dec 20, 2021
* Update props table

* Put props table subcomponents in global scope

* Update TextInput docs

* Update Link docs

* Update ActionList2 docs

* Update link docs

* Update text input docs

* Update actionlist docs

* Apply suggestions from code review

Co-authored-by: Jonathan Fuchs <[email protected]>

Co-authored-by: Jonathan Fuchs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants