-
Notifications
You must be signed in to change notification settings - Fork 642
Update component docs (Link, TextInput, ActionList2) #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm liking this 😻
| <Box as="td" colSpan={4} fontSize={1} verticalAlign="top" fontStyle="italic"> | ||
| Additional props are passed through to the <InlineCode><{elementName}></InlineCode> element. See{' '} | ||
| <Box as="td" colSpan={4} fontSize={1} verticalAlign="top"> | ||
| Additional props are passed to the <InlineCode><{elementName}></InlineCode> element. See{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding something like a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fair. 👍🏻
|
|
||
| ## Related components | ||
|
|
||
| - [ActionMenu](/drafts/ActionMenu2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this "ActionMenu2" in the link text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave that up to @siddharthkp
Co-authored-by: Jonathan Fuchs <[email protected]>
* Update props table * Put props table subcomponents in global scope * Update TextInput docs * Update Link docs * Update ActionList2 docs * Update link docs * Update text input docs * Update actionlist docs * Apply suggestions from code review Co-authored-by: Jonathan Fuchs <[email protected]> Co-authored-by: Jonathan Fuchs <[email protected]>
Part of #1701
Previews