-
Notifications
You must be signed in to change notification settings - Fork 620
Migrate Details, Token, and CounterLabel tests from Jest to Vitest #6369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
…l components Co-authored-by: pksjce <[email protected]>
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
@copilot - I think these tests are already converted. Can you check and if so close this PR |
You're absolutely right! I can confirm that these test files have already been converted to Vitest in the main branch. All three files (Details, Token, and CounterLabel) were migrated in commit d349e34 via PR #6348. My PR was based on an older commit and is therefore redundant. This PR should be closed since the work is already completed. |
This PR migrates the test files for Details, Token, and CounterLabel components from Jest to Vitest as part of the ongoing effort to modernize our test suite.
Changes Made
Test Files Migrated
packages/react/src/Details/__tests__/Details.test.tsx
packages/react/src/Token/__tests__/Token.test.tsx
packages/react/src/CounterLabel/CounterLabel.test.tsx
Migration Updates
describe
,expect
,it
,vi
)behavesAsComponent
usagecheckExports
usagetoHaveNoViolations
jest.fn()
tovi.fn()
@testing-library/react
instead ofutils/testing
Configuration Updates
vitest.config.browser.mts
include listjest.config.js
modulePathIgnorePatternsTest Results
--testPathPattern
)Verification
Fixes #6368.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.