Clean up warnings when running tests #3433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0a82aff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joelhawksley
force-pushed
the
20250409warnings
branch
from
2af6ff3 to
451926a
Compare
joelhawksley
commented
Apr 9, 2025
joelhawksley
commented
Apr 9, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@primer/view-components": minor | |||
There was a problem hiding this comment.
I'd consider this minor because we are changing the supported versions of Ruby/Rails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR updates a bunch of our dependencies to address various console warnings from tests. I also removed CI builds for Ruby 3.0 which has been EOL for 11 months: https://endoflife.date/ruby and removed all mentions of Rails < 7.1.
Risk Assessment
Dependencies only for the dev environment. Highly tested.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.