Skip to content

Publish routes in packaged gem #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Conversation

camertron
Copy link
Collaborator

What are you trying to accomplish?

In a recent PR, controllers and views serving Lookbook previews were moved from the Rails app in the demo/ directory into the main PVC Rails engine. This appeared to work well when depending on a local copy of PVC, but the OpenProject team ran into an issue when attempting to use the published gem. It appears gem releases do not contain the contents of the config/ directory, and therefore cannot access the routes defined in config/routes.rb. Correspondingly, this PR adds config/ to the list of files included in gem releases.

Integration

No changes necessary in production, this change is dev/test-only.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Jun 6, 2025

🦋 Changeset detected

Latest commit: eeea551

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron added the skip changeset Pull requests that don't change the library output label Jun 6, 2025
@camertron camertron marked this pull request as ready for review June 6, 2025 04:25
@camertron camertron requested a review from a team as a code owner June 6, 2025 04:25
@camertron camertron requested a review from joshblack June 6, 2025 04:25
@jonrohan jonrohan enabled auto-merge June 10, 2025 16:48
@jonrohan jonrohan added this pull request to the merge queue Jun 10, 2025
Merged via the queue into primer:main with commit 223a4c6 Jun 10, 2025
25 of 27 checks passed
@primer primer bot mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants