Skip to content

Addresses issue #7077 #7102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Addresses issue #7077 #7102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef3713a
Addresses issue #7077
Garima3110 Jun 21, 2024
ab1c4ae
Minor fix
Garima3110 Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/webgl/p5.Camera.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,15 +708,12 @@ p5.prototype.frustum = function (...args) {
*/
p5.prototype.createCamera = function () {
this._assert3d('createCamera');
const _cam = new p5.Camera(this._renderer);

// compute default camera settings, then set a default camera
const _cam = new p5.Camera(this._renderer);
_cam._computeCameraDefaultSettings();
_cam._setDefaultCamera();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want these two lines, which set the camera settings to be a perspective camera with the defaultparameters. I believe it's just the line below that needs to be taken out to not have it set itself as the active camera.


// set renderer current camera to the new camera
this._renderer._curCamera = _cam;

return _cam;
};

Expand Down