fixed geometry builder to accomodate vertexStrokeColors #7850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

Vaivaswat2244 wants to merge 2 commits into processing:dev-2.0 from Vaivaswat2244:buildgeometry

Open

fixed geometry builder to accomodate vertexStrokeColors #7850

added tests for stroke colours and small changes

Annotations

2 errors

build and test: test/unit/webgl/p5.RendererGL.js#L1427

AssertionError: expected [ 100, +0, +0, 100, 100, +0, …(1594) ] to deeply equal [ 217, 192, 192, 100, 178, …(1595) ] - Expected + Received Array [ - 217, - 192, - 192, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 217, - 192, - 192, 100, - 128, - 128, - 128, 0, 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 178, - 128, - 128, + 0, + 0, + 0, + 0, 100, + 0, + 0, 100, + 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, - 178, - 128, - 128, 100, - 128, - 128, - 128, + 0, 0, + 100, + 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 178, - 128, - 128, + 0, + 0, 100, + 0, + 0, + 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, - 178, - 128, - 128, + 100, + 0, + 0, 100, - 128, - 128, - 128, + 0, + 0, + 0, + 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 100, 0, 0, - 178, - 128, - 128, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, + 100, 100, - 178, - 128, - 128, + 0, + 0, 100, - 128, - 128, - 128, + 0, + 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 178, - 128, - 128, 100, + 0, + 0, 100, + 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, 100, 0, 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, 100, - 178, - 128, - 128, 100, - 178, - 128, - 128, + 0, + 0, + 100, + 100, + 0, + 0, + 100, + 100, + 0, + 0, + 100, 100, - 178, - 128, - 128, + 0, + 0, 100, - 217, - 192, - 192, 100, - 192, - 192, - 192, 0, - 128, - 128, - 128, 0, - 128, - 128, - 128, + 1

build and test

Process completed with exit code 1.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fixed geometry builder to accomodate vertexStrokeColors #7850

Uh oh!

Uh oh!

fixed geometry builder to accomodate vertexStrokeColors #7850

Uh oh!

Annotations

Re-running jobs...

Uh oh!

fixed geometry builder to accomodate vertexStrokeColors #7850

Are you sure you want to change the base?

Uh oh!

added tests for stroke colours and small changes

Uh oh!

fixed geometry builder to accomodate vertexStrokeColors #7850

Uh oh!

Annotations

Re-running jobs...