Skip to content

Conversation

aj-m
Copy link
Contributor

@aj-m aj-m commented Oct 3, 2025

Resolves: #1259
Changes:

  • keywords.txt: register short and Short keywords so they're correctly highlighted as datatypes.

Tests: I don't think they apply here, but it looks and runs right for me.
image

Copy link
Collaborator

@catilac catilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that we currently support the Short datatype. Can you remove the Short keyword addition?

Everything else works.

As for Short: You are welcome to create an issue around supporting the Short class. It will take more effort than adding a keyword to keywords.txt

@aj-m
Copy link
Contributor Author

aj-m commented Oct 8, 2025

Done. I assumed it made sense to add Short alongside short since it's a standard Java type is all.

@catilac
Copy link
Collaborator

catilac commented Oct 8, 2025

Thank you so much @aj-m! That is a totally understandable assumption to make. Approved 🎉 🙌🏽

@catilac catilac merged commit 5dc52be into processing:main Oct 8, 2025
6 checks passed
@catilac
Copy link
Collaborator

catilac commented Oct 8, 2025

@all-contributors please add @aj-m for code

Copy link
Contributor

@catilac

@aj-m already contributed before to code

@aj-m aj-m deleted the fix-syntax-datatype-short branch October 8, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

short data type not being highlighted in text editor
2 participants