Skip to content

Fix/flake8 consistent checks #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Fix/flake8 consistent checks #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01a70a3
fix: include flake8-isort in pre-commit
steve148 Mar 10, 2020
9ebfef3
fix: add flake8-docstrings to dev dependencies
steve148 Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repos:
rev: ""
hooks:
- id: flake8
additional_dependencies: [flake8-docstrings]
additional_dependencies: [flake8-docstrings, flake8-isort]
- repo: local
hooks:
- id: test
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"pre-commit",
"black",
"flake8",
"flake8-docstrings",
Copy link
Contributor

@DaleSeo DaleSeo Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how flake8-docstrings has been configured above without this dev dependency.

Copy link
Contributor Author

@steve148 steve148 Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so pre-commit's libraries / dependencies are separate from pip. So in the pre-commit config above, the repo field lists the place where pre-commit would pull the code from and it handles how it packages / manages versions of libraries which do checks.

If we want python / python to be the only thing that handles dependencies we could make these checks run against the local repository. We would move the checks under the repo: local grouping.

"flake8-black",
"flake8-isort",
"gitchangelog",
Expand Down