-
Notifications
You must be signed in to change notification settings - Fork 59
Align SDK with Validating Webhook behaviour on enableIngress #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align SDK with Validating Webhook behaviour on enableIngress #524
Conversation
|
Tested manually and it worked as expected. |
Bobbins228
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
26731da to
56163ca
Compare
|
Rebased - Good for merge? |
|
/lgtm |
56163ca to
d4121f8
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Issue link
Jira: https://issues.redhat.com/browse/RHOAIENG-6504
What changes have been made
enableIngressfield.Verification steps
false.trueChecks