FV: Extend timeout for dataplane apply after config restart. #10729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have seen this flake in enterprise tests.
fasaxc
added
docs-not-required
There was a problem hiding this comment.
Pull Request Overview
This PR extends the timeout for waiting for Felix dataplane apply operations after configuration restarts to address test flakiness. The change increases the timeout from the default (2s) to 5 seconds with 100ms polling intervals.
- Added explicit timeout and polling interval parameters to the
Eventuallyassertion - Added descriptive error message for better debugging when the assertion fails
| @@ -246,7 +246,8 @@ func waitForFelixInSync(felix *infrastructure.Felix) { | |||
| // And then we should see at least one apply to the dataplane. | |||
| Eventually(func() (int, error) { | |||
| return metrics.GetFelixMetricInt(felix.IP, "felix_int_dataplane_apply_time_seconds_count") | |||
| }).Should(BeNumerically(">", 0)) | |||
| }, "5s", "100ms").Should(BeNumerically(">", 0), | |||
There was a problem hiding this comment.
[nitpick] Consider using named constants for the timeout and polling interval values ("5s" and "100ms") to improve maintainability and make it easier to adjust these values consistently across the test suite if needed.
Suggested change
| }, "5s", "100ms").Should(BeNumerically(">", 0), | |
| }, DefaultTimeout, PollingInterval).Should(BeNumerically(">", 0), |
Copilot uses AI. Check for mistakes.
fasaxc
added
the
flake-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have seen this flake in enterprise tests.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.