Syntax 0.8, part 6: Parameterized term attributes #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
zeroeight-part6-macro-attrs
branch
2 times, most recently
from
ab361ba to
7e75668
Compare
3 tasks
stasm
force-pushed
the
zeroeight-part6-macro-attrs
branch
from
7e75668 to
1c684da
Compare
Pike
approved these changes
Nov 30, 2018
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
One thing I'd like to see changed: there's a "even more optimistic" change in variants parsing, and I'm not that optimistic.
r=me with that.
fluent/src/resource.js
Outdated
| let key = test(RE_NUMBER_LITERAL) | ||
| ? parseNumberLiteral() | ||
| : match(RE_IDENTIFIER); | ||
| : match(RE_REFERENCE)[2]; |
Contributor
There was a problem hiding this comment.
Can we keep the level of strictness here that we used to have? i.e., ensure that sigil and attribute are undefined?
stasm
force-pushed
the
zeroeight-part6-macro-attrs
branch
from
a88d3a6 to
cb22f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part 6 of #303. Depends on #312.