Remove variant lists #206
Remove variant lists #206
Conversation
stasm
force-pushed
the
remove-variant-lists
branch
from
7a2039f to
ee1d8b5
Compare
stasm
force-pushed
the
remove-variant-lists
branch
from
ee1d8b5 to
d894a70
Compare
stasm
force-pushed
the
remove-variant-lists
branch
2 times, most recently
from
1c70ca8 to
4695aa7
Compare
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
There's technical changes I'd like to see here.
I think it'd be good to have tests that cover the grounds we're leaving behind, and declare them as parsing errors. With that, we at least prevent accidental syntax re-use, and keep a reminder that we've tried this and didn't like at least some of it.
There's also a ton of conflicts and there'll probably be more by the time 0.8 is out, but we'll get there when it's time.
test/fixtures/member_expressions.ftl
Outdated
| @@ -1,6 +1,5 @@ | |||
| variant-expression = {-term[case]} | |||
There was a problem hiding this comment.
Should we keep this as an error test?
There was a problem hiding this comment.
I added a new fixture file, called obsolete.ftl, with a few examples of discontinued syntax. Thanks for the suggestion.
| -simple-identifier = | ||
| { | ||
| simple-identifier = | ||
| { $sel -> |
There was a problem hiding this comment.
Can you cross-check which of these are already tested in select_expressions.ftl ?
There was a problem hiding this comment.
I checked. select_expressions.ftl is mostly about selectors and things like empty variant values. In variant_keys.ftl I'd like to test different variant keys and their errors. I made a few changes in select_expressions.ftl to simplify the variant keys used there (key or one and two for nested placeables).
stasm
force-pushed
the
remove-variant-lists
branch
from
4695aa7 to
ab9bd58
Compare
2 participants
Fix
#204#214.