Reference tests for patterns starting with special chars #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
reviewed
Aug 10, 2020
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
Is wrapping the patterns in a select expression necessary here?
Contributor
Author
|
Ah, good point, I went by the test case from the original issue, but going by the EBNF, the test cases can be made more minimal. |
stasm
force-pushed
the
special-chars-start
branch
from
fa8da21 to
2091392
Compare
stasm
added a commit
to stasm/fluent.js
that referenced
this pull request
Aug 10, 2020
stasm
force-pushed
the
special-chars-start
branch
from
2091392 to
6f18997
Compare
Contributor
Author
|
I think Travis is having a hiccup but I'll look again into the CI error tomorrow. |
Pike
suggested changes
Aug 11, 2020
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
I've cleared the caches on travis and rerun the build, and that failed for an actual error.
The OK group comment is in projectfluent/fluent.js#513, so I expect you want to add that back here?
stasm
force-pushed
the
special-chars-start
branch
from
6f18997 to
03099b9
Compare
stasm
added a commit
to projectfluent/fluent.js
that referenced
this pull request
Aug 14, 2020
* Port parser reference tests projectfluent/fluent#313 * Don't drop to newline when patterns start with special chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests for projectfluent/fluent.js#512.