Add an intermediate Placeable production for Expressions within Patterns #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `Placeable` production as a wrapper for expressions in patterns. This allows storing more precise information about the whitespace around the placeable's braces. Separated the `expr` type into `inline_expr` and `block_expr`. This mirrors the EBNF, where a select expression cannot by an argument to a call expression nor selector of another select expression without being wrapped in braces.
zbraniecki
approved these changes
Aug 8, 2017
This was referenced Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47.
Added the
Placeableproduction as a wrapper for expressions inpatterns. This allows storing more precise information about the
whitespace around the placeable's braces.
Separated the
exprtype intoinline_exprandblock_expr. Thismirrors the EBNF, where a select expression cannot by an argument to
a call expression nor selector of another select expression without
being wrapped in braces.