Bug 1412808 - Remove the LITERAL helper. #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
approved these changes
Oct 30, 2017
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
I'd avoid the trailing whitespace decision in this patch, otherwise, r=me.
tests/migrate/test_concat.py
Outdated
| evaluate(self, msg).to_json(), | ||
| ftl_message_to_json(''' | ||
| channel-desc = You are on the { $channelname } channel. | ||
| channel-desc = You are on the { $channelname } channel.\u0020 |
Contributor
There was a problem hiding this comment.
This smells like anticipating a particular solution to bug 1374246. Want to remove the trailing whitespace in line 153 instead?
Its most common use-case can be fullfilled with a simple
FTL.TextElement() because CONCAT is also capable of concatenating
TextElements and Placables.
Its other use-case (defining a hard-coded value for a Message) is rare
and the alternative is not too bad:
FTL.Pattern([
FTL.TextElement("Hardcoded value")
])
Its third use-case was in REPLACE as the foreach function. That's
already covered by the default value of foreach, however.
stasm
force-pushed
the
migrate-remove-literal
branch
from
1755713 to
5f24a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1412808
Its most common use-case can be fullfilled with a simple FTL.TextElement() because CONCAT is also capable of concatenating TextElements and Placables.
Its other use-case (defining a hard-coded value for a Message) is rare and the alternative is not too bad:
Its third use-case was in REPLACE as the foreach function. That's already covered by the default value of foreach, however.