Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented Nov 23, 2023

Based on the benchmark, it speeds up by about 2x for the Ubuntu instances. While extracting the cache tarball for the Windows instance could be further sped up, with a tar binary that supports zstd.
See rht#12.

The cache should be automatically cleared every month. Or alternatively, create a lockfile (either via Poetry of pip-tools) that is automatically updated via Dependabot. Regardless, this is out of the scope of this PR.

@codecov
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70b2902) 77.10% compared to head (bf6ed10) 77.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1885   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          15       15           
  Lines         974      974           
  Branches      214      214           
=======================================
  Hits          751      751           
  Misses        195      195           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Based on the benchmark, it speeds up by about 2x for the Ubuntu instances. While extracting the cache tarball for the Windows instance could be further sped up, with a `tar` binary that supports `zstd`.
See #12.

The cache should be automatically cleared every month. Or alternatively, create a lockfile (either via Poetry of `pip-tools`)  that is automatically updated via Dependabot. Regardless, this is out of the scope of this PR.
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 838e216 into projectmesa:main Dec 2, 2023
@EwoutH EwoutH added the ci Release notes label label Jan 9, 2024
@rht rht deleted the faster-ci-test branch January 19, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Release notes label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants