Add experimental warning to DiscreteEventScheduler #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the DiscreteEventScheduler as experimental for now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
+ Coverage 79.10% 79.14% +0.03%
==========================================
Files 15 15
Lines 1096 1098 +2
Branches 236 236
==========================================
+ Hits 867 869 +2
Misses 198 198
Partials 31 31 ☔ View full report in Codecov by Sentry. |
Corvince
approved these changes
Dec 23, 2023
EwoutH
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the DiscreteEventScheduler (added in #1890) as experimental for now. Feedback can be collected in discussion #1923.
@Corvince and @tpike3 please review and merge.