-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add guide for GSoC contributors #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
EwoutH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great start already! I have a few (mostly minor) suggestions.
I'm really curious how the other (ex) GSoC contributors view this guide! Does it tell you what you wish you wanted you'd knew before writing your proposal?
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
|
Thanks for your reviews, I agree with all of them so I added them. I integrated a few feedbacks already from @Sahil-Chhoker, but I'd be curious to see what the others think of it indeed :) |
|
Maybe you can also link to the guide on the main Readthedocs page Line 68 in 6dabdbf
|
Sahil-Chhoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks solid.
|
Hi @EwoutH (and @colinfrisch), Ewout asked me to share my thoughts on this guide from a new contributor's perspective. First, I think it's a great guide! If I had this 3 days ago, I would have understood the GSoC expectations much better. As a new contributor, I did find a few small things that were a bit confusing for me as a complete beginner:
These are just my honest thoughts as someone new to the project. I hope this is helpful! |
I wrote this line to explain what I’m trying to say, this applies only after you’ve seen the project you’ll be working on. Every project shouldn’t just be a simple feature or bug fix; it should be a solution to a problem with its own trade-offs. 'Pressing matters' defines just that, working on what matters more. 'Fluff' is the unimportant stuff people tend to add to their proposals just to make them longer. In my opinion, this is best understood once contributors have seen their respective projects. Let me know what you think. |
|
Would something like “to separate the main issues from the non-essentials” make it more clear?
I think this captures it well. Maybe just add (a version of) this? |
|
Thanks for the feedback ! I integrated everything. Anything else you want me to add/modify ? |
|
I think is an awesome start! If we think of more we can always improve it further. Now we have make this document findable, otherwise nobody reads it. I would suggest linking to it in 3 places:
I would suggest in all three to use the full name and the abbreviation, something like “For participating in the Google Summer of Code (GSoC), checkout Mesa’s GSoC guide.” I’m thinking, do we need to do anything to let Readthedocs build this document (@tpike3 / @quaquel)? |
Co-authored-by: Ewout ter Hoeven <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I’m good. Readthedocs renders nicely. Thanks!
Let give the rest of the team a bit of time to look at it.
|
Let’s keep this a living document and keep updating where relevant. Thanks Colin for setting this up! |
GSoC guide for new contributors looking to join Mesa for GSoC.