#257: Add gauge for total fields mapped in an index #386

jnadler · 2020-09-10T01:16:46Z

This PR replaces #364 so that I can take over the work started by @msodi. The original PR feedback from @sysadmind has been addressed.

jnadler · 2020-09-10T20:39:48Z

@sysadmind @zwopir anyone willing to review this change? I think a lot of folks who use ES for logging will appreciate this change, logging often causes field cardinality explosions and being able to alert on those before they cause an outage is a big win. Thanks!

sysadmind

This fixes the feedback I had from the original PR.

sysadmind · 2020-09-11T20:02:49Z

collector/indices_mappings.go

+	}
+
+	var imr IndicesMappingsResponse
+	if err := json.NewDecoder(res.Body).Decode(&imr); err != nil {


This is not a big deal, but it would be cleaner to use json.Unmarshal() instead. The decoder isn't guaranteed to read the whole body of the response and could leave the connection lingering open and unusable. That also means you can explicitly close the body after reading the whole thing to ensure that the connections get returned to the pool for reuse.

https://changelog.com/gotime/141#transcript-111
https://pkg.go.dev/net/http?tab=doc#Response see the notes on the Body property of the Response here.

sysadmind · 2020-09-11T20:03:55Z

collector/indices_mappings.go

+		err = res.Body.Close()
+		if err != nil {
+			_ = level.Warn(im.logger).Log(
+				"msg", "failed to close http.Client",


This is the body, not the client.

jnadler · 2020-09-11T20:48:58Z

Thanks for the feedback @sysadmind !! Just pushed some updates.

jnadler · 2020-09-11T22:07:39Z

Just tested this against one of our prod clusters, the new gauge elasticsearch_indices_mappings_stats_field_count is working as expected.

jnadler · 2020-09-14T15:31:36Z

Thanks @sysadmind, appreciate your help! @zwopir would you please merge?

repl-mike-roest · 2021-04-15T17:21:41Z

Any motion on this PR? This is something we would really like to have as well

jnadler · 2021-04-15T17:40:57Z

@repl-mike-roest no PRs have been merged in 15 months; we're running a build off this branch since september with good results. @zwopir any chance you'd be willing to add others (maybe @sysadmind ?) as admins on this project so that they can merge and release to keep it alive?

repl-mike-roest · 2021-04-15T17:54:38Z

@jnadler I've been trying to build it locally as well to test if it will work with what I'm trying to pull from our clusters. However I seem to be hitting a build failure when trying to build the docker container

docker build -t elasticsearch_exporter .
<docker output>
go: cannot find main module, but found vendor/vendor.json in /go/src/github.com/justwatchcom/elasticsearch_exporter
        to create a module there, run:
        go mod init
>> formatting code
go: cannot find main module, but found vendor/vendor.json in /go/src/github.com/justwatchcom/elasticsearch_exporter
        to create a module there, run:
        go mod init
make: *** [Makefile:37: format] Error 1

I tried updating the docker file to use a go 1.13,1.14 and 1.15 base image from the quay.io/prometheus/golang-builder and all of them fail with slightly different errors (errors above are with the Dockerfile as is so using latest which seems to be 1.16)

Any ideas?

jnadler · 2021-04-15T18:22:55Z

try go mod vendor then make docker

repl-mike-roest · 2021-04-15T19:40:26Z

I looks like something that is broken upstream with promu prometheus/promu#218 if I update the docker file back to quay.io/prometheus/golang-builder:1.15-main then I get the same error that is reported in the promu issue.

jnadler · 2021-04-15T21:14:38Z

strange i got a different vendoring error until running go mod vendor but was fine with either make build or make docker after that; i presume there's been some drift in the dependencies

i'm on go 1.16.2 but not sure it should matter; make docker does the actual go build inside a container so it should be consistent for everyone i'd think, that should prevent most classes of "builds on my machine" issues

repl-mike-roest · 2021-04-16T12:31:06Z

With docker 1.16.2 if I do

go mod init  (this is needed cause if I just do go mod vendor it just complains there is no go.mod file)
go mod tidy
go mod vendor
make build

I get a error go: inconsistent vendoring in /Users/mike.roest/Workspaces/elasticsearch_exporter:

Doing another go mod vendor then make build again all the package issues seem to be resolved but getting an actual compile failure:

/main.go:170:27: undefined: prometheus.Handler
!! command failed: build -o /Users/mike.roest/Workspaces/elasticsearch_exporter/elasticsearch_exporter -ldflags -s -X github.com/justwatchcom/elasticsearch_exporter/vendor/github.com/prometheus/common/version.Version=1.1.0 -X github.com/justwatchcom/elasticsearch_exporter/vendor/github.com/prometheus/common/version.Revision=ab8add4ff4188654f4af7b1a1498679080de80e8 -X github.com/justwatchcom/elasticsearch_exporter/vendor/github.com/prometheus/common/version.Branch=HEAD -X github.com/justwatchcom/elasticsearch_exporter/vendor/github.com/prometheus/common/version.BuildUser=mike.roest@cgdv-b0105 -X github.com/justwatchcom/elasticsearch_exporter/vendor/github.com/prometheus/common/version.BuildDate=20210416-11:54:19  -a -tags netgo github.com/justwatchcom/elasticsearch_exporter: exit status 2
make: *** [build] Error 1

Then following this floyd871/prometheus_oracle_exporter#22 suggestion I now have it building with make build and make docker

repl-mike-roest · 2021-04-16T17:49:21Z

I've expanded on your changes here @jnadler to also add the total_fields limit setting
repl-mike-roest/elasticsearch_exporter@55deb73...9e9be05

This allows for adding alerts on a total_fields approaching the limit

jnadler · 2021-04-16T21:38:59Z

that's great @repl-mike-roest ! Hey @zwopir totally understand that you're busy but would you consider making someone else an admin? Or even turning this repo over to someone else who will review/merge PRs and do releases?

jnadler · 2022-08-16T20:32:10Z

Hey @SuperQ ... I see that you've been maybe merging things and even did a release recently, it's so good to see that someone is keeping this thing alive!

Any chance of merging this?

sysadmind · 2022-08-25T02:35:39Z

This needs a rebase before it can be merged. After a rebase, I can take a look just to make sure everything still looks good and merge. Thank you!

jnadler · 2022-11-03T20:32:47Z

Equivalent functionality appears to have been merged in #411

msodi and others added 3 commits July 8, 2020 16:48

prometheus-community#257: Add gauge for total fields mapped in an index

1ca814e

Add gauge for field count per index

44232ba

Fix auto refactor fail

079f8a5

jnadler mentioned this pull request Sep 10, 2020

#257: Add gauge for total fields mapped in an index #364

Closed

sysadmind approved these changes Sep 11, 2020

View reviewed changes

Jeff Nadler added 3 commits September 11, 2020 13:24

Fix index request error log

631e8a4

Fix index request error log

cad3231

Use json.Unmarshal to address pr feedback

ab8add4

Jeff Nadler added 2 commits September 11, 2020 16:22

Move to go modules

35176c3

Update libs, prom client

a708fc5

sysadmind approved these changes Sep 12, 2020

View reviewed changes

repl-mike-roest mentioned this pull request Apr 16, 2021

Build process with docker is broken #408

Closed

repl-mike-roest mentioned this pull request Apr 27, 2021

Add Gauge for total_fields setting on a index #411

Merged

jnadler force-pushed the issue/257 branch from 7b47d49 to a708fc5 Compare October 27, 2022 16:45

jnadler closed this Nov 3, 2022

#257: Add gauge for total fields mapped in an index #386

#257: Add gauge for total fields mapped in an index #386

Uh oh!

Conversation

jnadler commented Sep 10, 2020

Uh oh!

jnadler commented Sep 10, 2020

Uh oh!

sysadmind left a comment

Choose a reason for hiding this comment

Uh oh!

sysadmind Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

sysadmind Sep 11, 2020

Choose a reason for hiding this comment

Uh oh!

jnadler commented Sep 11, 2020

Uh oh!

jnadler commented Sep 11, 2020

Uh oh!

jnadler commented Sep 14, 2020

Uh oh!

repl-mike-roest commented Apr 15, 2021

Uh oh!

jnadler commented Apr 15, 2021

Uh oh!

repl-mike-roest commented Apr 15, 2021

Uh oh!

jnadler commented Apr 15, 2021

Uh oh!

repl-mike-roest commented Apr 15, 2021

Uh oh!

jnadler commented Apr 15, 2021

Uh oh!

repl-mike-roest commented Apr 16, 2021

Uh oh!

repl-mike-roest commented Apr 16, 2021

Uh oh!

jnadler commented Apr 16, 2021

Uh oh!

jnadler commented Aug 16, 2022

Uh oh!

sysadmind commented Aug 25, 2022

Uh oh!

jnadler commented Nov 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants