Skip to content

fix _/node/stats related metrics #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2021
Merged

fix _/node/stats related metrics #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1649533
fix _/node/stats related metrics
0x46616c6b Jun 15, 2021
df0f1d0
remove skipping test for 7.13.1
0x46616c6b Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion collector/nodes_response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type NodeStatsNodeResponse struct {
ThreadPool map[string]NodeStatsThreadPoolPoolResponse `json:"thread_pool"`
JVM NodeStatsJVMResponse `json:"jvm"`
Breakers map[string]NodeStatsBreakersResponse `json:"breakers"`
HTTP map[string]int `json:"http"`
HTTP map[string]interface{} `json:"http"`
Transport NodeStatsTransportResponse `json:"transport"`
Process NodeStatsProcessResponse `json:"process"`
}
Expand Down
5 changes: 0 additions & 5 deletions collector/nodes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ func TestNodesStats(t *testing.T) {
for hn, handler := range handlers {
t.Run(fmt.Sprintf("%s/%s", hn, ver), func(t *testing.T) {

// TODO(@sysadmind): Remove this skip once we have a fix for v7.13.1 of elasticsearch
if ver == "7.13.1" {
t.Skip("7.13.1 has a breaking change and the fix has not yet been implemented.")
}

ts := httptest.NewServer(handler)
defer ts.Close()

Expand Down