Add FreeBSD (+others?) support to smartmon #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
discordianfish
pushed a commit
that referenced
this pull request
Sep 2, 2019
In some cases apt.sh could output duplicated arch values causing the following error: Aug 29 12:12:22 host123 prometheus-node-exporter[2235]: time="2019-08-29T12:12:22Z" level=error msg="error gathering metrics: [from Gatherer #2] collected metric \"apt_upgrades_pending\" { label:<name:\"arch\" value:\"Debian/Ubuntu\" > label:<name:\"origin\" value:\"PostgreSQLfor\" > gauge:<value:6 > } was collected before with the same name and label values\n" source="log.go:172" Signed-off-by: Andrey Arapov <[email protected]>
dswarbrick
reviewed
May 23, 2023
| )" | ||
|
|
||
| # Find the smartctl binary, usually in /usr/sbin (Linux) or /usr/local/sbin (FreeBSD) | ||
| SMARTCTL_BIN="$(whereis smartctl | awk '{print $2}')" |
There was a problem hiding this comment.
Wouldn't this essentially just be the same as omitting the path prefix from the smartctl commands, and letting the shell's PATH find it?
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FreeBSD support:
Tested on Debian 9, as well as FreeBSD 12.