SCRAM support, go modules, simpler builds #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and modernize to go modules Make building simpler: - move cmd/postgres_exporter to . - use go build, not mage - add a docker-compose file that spawns all postgres versions and run tests against each of them. - remove the tools directory with linting tools. i've run golangci-lint locally. - no copying of assets Not done: - travis ci tests - running (passing) the existing integration tests - running golangci-lint automatically (instead of the old linters). but then probably run it through docker. the source has a lot of go dependencies, don't want to make our go.mod huge. the alternative is a separate tools dir and go.mod file (instead of a tools.go in the root dir). - increasing test coverage
shouldn't have been committed
Member
|
FWIW, the build toolchain in this repo is challenging, it might be me though, since I am new to go and the ecosystem around it |
Closed
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried just updating github.com/lib/pq to v1.1.1. The build system is a bit much compared to the code, I didn't get it running before deciding to try to switch to go modules. I'm now running this to monitor a postgres11 with SCRAM authentication.
I know the changes are big for just updating a lib/pq. But I wouldn't be surprised no pull request has been created for this so far because of the build tooling. This is more of a starting point, I haven't done anything with Travis CI tests. I can understand if you don't want to change how builds are done.
This could solve #231.
Repeated from the message in the first (main) commit:
Make building simpler:
Not done: