Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 23, 2024

Fixes #1446

@ywwg
Copy link
Member

ywwg commented Feb 23, 2024

this requires some test changes, too, sorry

@ywwg
Copy link
Member

ywwg commented Feb 23, 2024

I had been working on this but it should be easy to move here

#1448

@ywwg
Copy link
Member

ywwg commented Feb 23, 2024

thank you for this, we're going to fix up the other failures in my previous WIP fix here: #1448

@ArthurSens
Copy link
Member

thanks for the PR, we got everything working on #1448!

@ArthurSens ArthurSens closed this Feb 23, 2024
@ghost ghost deleted the chore/fix-promlint branch February 24, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build break after updating

3 participants