Fix: resolve Go module zip error by renaming VERSION to VERSION.txt #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename root VERSION file to VERSION.txt to avoid case-insensitive collision with version/ directory - Update Makefile.common and RELEASE.md to reference VERSION.txt - Fixes go: create zip: version/info.go: case-insensitive file name collision: 'VERSION' and 'version' Signed-off-by: Pallavi Khade <[email protected]>
|
@bastischubert @SuperQ |
|
This will not work, as the The good news is that we don't actually use those tools and hence the |
|
Yes, the fix is to remove VERSION. |
|
Closing in favor of #853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
#850
#851
This PR resolves an issue where Go module zip creation fails on case-insensitive filesystems (such as Windows and macOS) due to a filename collision:
Root cause:
The repository shipped both a root VERSION file and a version package directory. On case-insensitive filesystems, these collide, causing go get -u and module zip creation to fail.
What this PR does:
Renames the root VERSION file to VERSION.txt
Updates all references in Makefile.common and RELEASE.md to use VERSION.txt
This change eliminates the collision and allows Go module operations to work correctly on all platforms.