Null dereference in error message when stub is null #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There would be deference of null because stub is null
mgravell
approved these changes
Apr 15, 2025
|
Yep, good catch, thanks. |
This was referenced Jul 27, 2025
This was referenced Aug 4, 2025
This was referenced Aug 4, 2025
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following code, there's a potential null dereference when constructing the message for ThrowArgumentNullException:
if (stub is null) ThrowHelper.ThrowArgumentNullException(nameof(stub), $"No suitable repeated serializer resolved for {stub.ForType.NormalizeName()}");Code: https://github.com/protobuf-net/protobuf-net/blob/3.2.52/src/protobuf-net/Internal/Serializers/RepeatedDecorator.cs#L13
When stub is null, the code tries to access stub.ForType to include in the message, which will cause a null dereference exception before the ThrowArgumentNullException would be executed.