fix: make parsedOptions appear in method JSON representation #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
force-pushed
the
json-parsed-options
branch
from
664b2fd to
c8528ed
Compare
murgatroid99
approved these changes
Nov 13, 2020
This was referenced May 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #1256 and adds properly parsed options to JSON representation of methods.
Background: we need it to be able to read
google.api.httpmethod annotations which may include nested lists (additional_bindings) that the default options parsing cannot handle. #1256 introducedparsedOptionsproperty that represents options as a proper (possibly nested) object but it did not go to JSON representation (which we use). Adding it there.