[php][compiler][ext] - Add missing has* methods and other well known types #20636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioBatSilva
commented
Mar 10, 2025
| @@ -319,6 +319,13 @@ static PHP_METHOD(google_protobuf_Api, setSourceContext) { | |||
| RETURN_COPY(getThis()); | |||
| } | |||
|
|
|||
| static PHP_METHOD(google_protobuf_Api, hasSourceContext) { | |||
There was a problem hiding this comment.
php/ext/google/protobuf/wkt.inc was generated with bazel build //php:gen_wkt_sources.
Unsure why this file is in git..
There was a problem hiding this comment.
This will be automatically updated after the PR is submitted, so you could leave it out of the PR if you wanted. But there's also no harm in updating it eagerly, as you have.
acozzette
added
php
🅰️ safe for tests
FabioBatSilva
force-pushed
the
php-wellknown-types-predicate-methods
branch
from
a3f9c82 to
65aece9
Compare
acozzette
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
This was referenced Apr 10, 2025
haberman
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix : #20036