-
Notifications
You must be signed in to change notification settings - Fork 15.8k
Updating setuptools to patch CVE-2025-47273 #22094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating setuptools to patch CVE-2025-47273 #22094
Conversation
@mkruskal-google Can you allow tests to run again? I believe that my latest commit updating Bazel to 7.4.0 should fix this, at least partially. The reason why it wasn't working properly appears to have been bazelbuild/bazel#4327 , which was fixed in Bazel 7.4.0 . |
Actually — scratch that. The culprit seems to be a new bug that I seem to have found in Bazel bazelbuild/bazel#26255 :( I'll move this PR to Draft status while that Bazel bug is outstanding |
@mkruskal-google can you allow tests to run for this again? Per a suggestion from the Bazel team at bazelbuild/bazel#26255 (comment) I added an |
@acozzette Thanks — looks like there are still some test failures here for a few reasons.
I believe that this can be updated in the files within
|
@aaronmaxlevy Thank you for all your work on this! Unfortunately upgrading our Bazel version is a non-trivial process, because there are a handful of Docker images that need to be rebuilt in addition to updating .bazeliskrc and the .yml files. I will try to find time to do that later this afternoon or tomorrow, though. Let me rerun the tests now to see if the CMake issue build error goes away. |
No problem :) Happy to help. Looks like the CMake issue has resolved now, which is good. |
…d to fail on Windows and fallback to the default python path
8b55fb5
to
6ce6928
Compare
@acozzette the Windows test should pass now if you re-run it. Turns out that the Pip package installation stuff doesn't actually work on Windows. The current build process ends up falling back to the system python's installed version of setuptools on Windows from what I can tell, which is what I changed the new wrapper script to also do. See protobuf/python/dist/system_python.bzl Line 176 in 960e790
WARNING: could not install pip dependencies in the output, e.g. https://github.com/protocolbuffers/protobuf/actions/runs/16047228021/job/45281342761?pr=22509#step:4:566
|
This is necessary for upgrading setuptools, because older Bazel versions apparently can't handle whitespace in file names: #22094 PiperOrigin-RevId: 778242489
This is necessary for upgrading setuptools, because older Bazel versions apparently can't handle whitespace in file names: #22094 PiperOrigin-RevId: 780210543
@acozzette thank you so much for your help in getting this merged / rolled out! |
You're welcome and thank you for sending us the fix! |
No problem! |
Updating setuptools to patch CVE-2025-47273
Also updated Bazel to 7.4.0 due to bazelbuild/bazel#4327
Fixes #22165