feat(m365): add onboarding auth method forms #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

HugoPBrito wants to merge 5 commits into master from PRWLR-7569-create-different-flows-of-onboarding-in-m-365

Member

HugoPBrito commented Jul 21, 2025

Context

Currently we have 2 auth methods (SP and SP+User) in the same form. This PR aims to introduce support for different onboarding flows in Microsoft 365 provider in separate forms.

Description

This PR implements logic to differentiate onboarding flows for M365 provider.

Checklist

Are there new checks included in this PR? Yes / No
- If so, do we need to update permissions for the provider? Please review this carefully.
Review if the code is being covered by tests.
Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
Review if backport is needed.
Review if is needed to change the Readme.md
Ensure new entries are added to CHANGELOG.md, if applicable.

API

Verify if API specs need to be regenerated.
Check if version updates are required (e.g., specs, Poetry, etc.).
Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          feat: add select auth method form

186851e

HugoPBrito requested a review from a team as a code owner

July 21, 2025 08:40

HugoPBrito changed the title ~~feat(m365): add onboarding auth method form~~ feat(m365): add onboarding auth method forms

github-actions bot added the component/ui label

Contributor

github-actions bot commented Jul 21, 2025 •

edited

Loading

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

api
ui
prowler

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

✅ All necessary CHANGELOG.md files have been updated. Great job! 🎉

✅ All necessary CHANGELOG.md files have been updated. Great job! 🎉

HugoPBrito requested review from a team as code owners

July 21, 2025 08:42

github-actions bot added the component/api label

codecov bot commented Jul 21, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (3892165) to head (625afc0).
Report is 32 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8332      +/-   ##
==========================================
+ Coverage   88.08%   88.94%   +0.86%     
==========================================
  Files         897      192     -705     
  Lines       27645    15637   -12008     
==========================================
- Hits        24352    13909   -10443     
+ Misses       3293     1728    -1565

Flag	Coverage Δ
api	`94.89% <ø> (?)`
prowler	`75.15% <ø> (-12.94%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
prowler	`75.15% <ø> (-12.94%)`	⬇️
api	`94.89% <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

HugoPBrito force-pushed the PRWLR-7569-create-different-flows-of-onboarding-in-m-365 branch from 934f51a to ad9323a Compare

July 21, 2025 13:41

MrCloudSec reviewed

View reviewed changes

api/pyproject.toml Outdated Show resolved Hide resolved

MrCloudSec reviewed

View reviewed changes

poetry.lock Outdated Show resolved Hide resolved

MrCloudSec reviewed

View reviewed changes

api/pyproject.toml Outdated Show resolved Hide resolved

MrCloudSec requested changes

View reviewed changes

Member

MrCloudSec left a comment •

edited

Loading

Please, review my comments. Also, add the UI/API changelogs and put screenshots of the new changes in the description? Where are the changes of the API? Thanks.

HugoPBrito requested a review from a team as a code owner

July 22, 2025 13:24

HugoPBrito added 2 commits

July 22, 2025 15:59


          fix: linter

6d94cd5


          chore: enhance label

638f44e

HugoPBrito force-pushed the PRWLR-7569-create-different-flows-of-onboarding-in-m-365 branch from c452838 to 638f44e Compare

July 22, 2025 13:59

HugoPBrito removed request for a team

July 22, 2025 14:00

HugoPBrito added 2 commits

July 22, 2025 16:07


          chore: add to changelog

40219d5


          chore: resolve conflicts

7ae8ed0

MrCloudSec self-requested a review

July 22, 2025 14:13

paabloLC assigned HugoPBrito

paabloLC requested changes

View reviewed changes

ui/app/(prowler)/providers/(set-up-provider)/add-credentials/page.tsx

                     {((searchParams.type === "aws" && searchParams.via === "credentials") ||
                       (searchParams.type === "gcp" && searchParams.via === "credentials") ||
-                      (searchParams.type !== "aws" && searchParams.type !== "gcp")) && (
+                      (searchParams.type === "m365" && searchParams.via === "credentials") ||
+                      (searchParams.type === "m365" &&

Member

paabloLC Jul 29, 2025

could you clarify what this is needed for and its purpose, please?

Member Author

HugoPBrito Jul 29, 2025

My intention was to add M365 to the group of providers that require a form to select the authentication method before showing the credentials form.

ui/components/providers/workflow/forms/base-credentials-form.tsx

+                          />
+                        )}
+                      {providerType === "m365" &&
+                        searchParamsObj.get("via") !== "service-principal-user" && (

Member

paabloLC Jul 29, 2025

we should avoid using this kind of condition (!==)

paabloLC added status/awaiting-reponse no-merge labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/api component/ui no-merge status/awaiting-reponse