Update to MCP 2025-06-18 specification and fix CI validation #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add _meta support to Content, ResourceContents, CallToolResult - Implement NumberOrString enum for request IDs with i64 support - Change ProtocolVersion to date-based format (YYYY-MM-DD) - Add title, annotations, and icons fields to Tool, Prompt, and Resource - Implement context-aware completion API (CompletionContext) - Add schemars integration as optional feature - Upgrade thiserror to v2.0 - Update all transport, server, and macro code for new types
Add missing optional fields (title, annotations, icons, _meta) to Tool, Resource, Prompt, CallToolResult, and ResourceContents structs across test files. Update Request id fields from json!() values to NumberOrString type with proper wrapping in Some(). Fix Content enum pattern matching to ignore _meta field. Upgrade thiserror dev-dependency from 1.0 to 2.0 workspace version to resolve linker conflicts.
Fix Request id fields and assertions in batch_tests, validation, and validation_tests. Replace json!() and Value::Null with NumberOrString type wrapped in Option. Add Arc import to batch_tests. Update is_null() method calls to is_none().
Apply cargo fmt formatting and remove unused Value imports from test files to satisfy CI requirements: - cargo fmt --all -- --check - cargo clippy --all-features --all-targets --release -- -D warnings - cargo test --all-features --release --verbose Changes: - Applied automatic code formatting across all modified files - Removed unused serde_json::Value imports from 5 test files in mcp-transport - All CI validation steps now pass successfully
Update pre-commit configuration to ensure local validation matches CI: - Update cargo clippy to use --all-features --all-targets --release - Update cargo test to include --all-features flag - Hooks now exactly match CI validation pipeline This ensures developers catch formatting and linting issues before pushing.
Code Coverage Report 📊Local Coverage: 19.90%
Coverage Details📋 Full Report: View on Codecov |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
PR Validation ResultsQuick Validation: ✅
Compatibility Check: ✅
Summary: ✅ All checks passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
MCP 2025-06-18 Protocol Updates
CI Validation Fixes
Test plan