Skip to content

Conversation

@fnune
Copy link
Member

@fnune fnune commented Oct 21, 2025

Proposed changes

Adds documentation for the deletion protection feature in Pulumi ESC and a blog post announcing its availability.

The deletion protection feature prevents accidental deletion of environments by requiring that protection be explicitly disabled before deletion. This helps safeguard production environments and shared configuration.

Changes:

  • Add deletion protection documentation page in administration section
  • Update administration index to include deletion protection
  • Create blog post announcing the feature

Related issues (optional)

Fixes: https://github.com/pulumi/pulumi-service/issues/33815

@fnune fnune force-pushed the fnune/document-and-announce-deletion-protection branch from 86ccd57 to c1146cf Compare October 21, 2025 10:15
@claude
Copy link
Contributor

claude bot commented Oct 21, 2025

Review Summary

This PR adds documentation and a blog post for the ESC deletion protection feature. The content is well-structured and mostly follows the style guide, but there are several issues that need to be addressed before merging.


Critical Issues

Missing more break in blog post

File: content/blog/esc-deletion-protection/index.md:17

The blog post is missing the more break after the first paragraph. According to BLOGGING.md, this is required to control what appears on the blog home page. Add this HTML comment after line 15.


Style Issues

1. Improper heading capitalization in blog post

File: content/blog/esc-deletion-protection/index.md

According to STYLE-GUIDE.md, H2 and deeper headings should use sentence case, not title case.

Line 21: Change to "How it works"
Line 26: Change to "Managing deletion protection"
Line 44: Change to "When to use deletion protection"
Line 58: Change to "Getting started"

2. Improper heading capitalization in documentation

File: content/docs/esc/administration/deletion-protection.md

Multiple headings use title case instead of sentence case:

Line 14: "Enabling deletion protection"
Line 43: "Deleting protected environments"
Line 58: "Visual indicators"
Line 67: "Use cases"

3. Missing blank line before heading

File: content/blog/esc-deletion-protection/index.md:30

According to STYLE-GUIDE.md, headings should be surrounded by blank lines. Add a blank line before line 30.

4. Navigation terminology

File: content/blog/esc-deletion-protection/index.md:28

According to STYLE-GUIDE.md, use "navigate" not "navigate to".

Change: "In the Pulumi Cloud console, navigate to your environment's settings"


Content Suggestions

  1. Blog post author - Line 8: The author is set to "pulumi" which is generic. Consider using a specific author ID.

  2. Blog post opening hook - Line 15: The opening is functional but could be more engaging.

  3. Missing file endings - Both new markdown files should end with a newline.


Positive Observations

  • Clear and concise documentation structure
  • Good use of code examples with bash syntax highlighting
  • Appropriate cross-linking between blog post and documentation
  • Visual indicators section is helpful for users
  • Permissions section clearly explains admin requirements
  • Use cases are practical and relevant

Checklist Before Merge

  • Add more break to blog post after first paragraph
  • Fix all heading capitalization (sentence case for H2+)
  • Add blank line before Managing deletion protection heading
  • Fix navigate to
  • Verify both files end with newlines
  • Test meta.png preview on blog home page
  • Verify internal link resolves correctly

Mention @claude if you would like me to review again after making changes or if you need help with any of these suggestions.

Document and announce ESC deletion protection feature

Adds documentation for the deletion protection feature in Pulumi ESC
and a blog post announcing its availability.

The deletion protection feature prevents accidental deletion of
environments by requiring that protection be explicitly disabled before
deletion. This helps safeguard production environments and shared
configuration.

Changes:
- Add deletion protection documentation page in administration section
- Update administration index to include deletion protection
- Create blog post announcing the feature
@fnune fnune force-pushed the fnune/document-and-announce-deletion-protection branch from c1146cf to 1792e40 Compare October 21, 2025 10:22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process here? Do we get a new image for this, or is this one OK?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. I didn't even know this was there.

Did this come from the blog template? Maybe we should ask the marketing folk to make us one for blogs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm fine with running with this one for the moment, since I'm sure we have a bunch of blog posts using it.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@fnune fnune merged commit 7e8e1d4 into master Nov 3, 2025
8 checks passed
@fnune fnune deleted the fnune/document-and-announce-deletion-protection branch November 3, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants