This repository was archived by the owner on Jun 5, 2020. It is now read-only.
MODULES-4221 - Allow boolean values to be passed #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/puppet/type/git_config.rb
Outdated
|
|
||
| validate do | ||
| fail('it is required to pass "value"') if self[:value].nil? || self[:value].empty? || self[:value] == :absent | ||
| fail('it is required to pass "value"') if self[:value].nil? || (self[:value].respond_to?(:emtpy?) && self[:value].empty?) || self[:value] == :absent |
There was a problem hiding this comment.
looks like a typo - :emtpy => empty
- Currently have to quote all boolean values in order to pass validation of empty? this fix adds a check to ensure the value type responds to empty?
…caught with modulesync - A lot of ruby dependent issues need to be resolved include rake and fast_gettext
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix adds a check to ensure the value type responds to empty?