Skip to content

Incorrect definition of a breaking change #8

@ekohl

Description

@ekohl

Describe the Bug

puppetlabs/puppetlabs-apache#2165 is considered a breaking change by the rangefinder, but it isn't. It doesn't change any Puppet code and only makes sure puppet-strings will actually read the comment string.

Expected Behavior

It should correctly detect that the Puppet AST is unchanged for the parts that matter.

Steps to Reproduce

See the related PR, which changes:

# A comment

define apache::vhost () {}

To:

# A comment
define apache::vhost() {}

Environment

  • Github

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions