(GH-65) Tokenise Node names correctly #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the tokeniser always thought node names must a be a single string, however they can also be regular expressions and the keyword default. And they can be a list of these separate by commas. This commuit updates the node regular expressions for all of these types of node names and adds tests for these scenarios
glennsarti
force-pushed
the
gh-65-node-defn
branch
from
215a8d3 to
a78f394
Compare
glennsarti
changed the title
jpogran
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Previously the tokeniser always thought node names must a be a single string,
however they can also be regular expressions and the keyword default. And they
can be a list of these separate by commas. This commuit updates the node
regular expressions for all of these types of node names and adds tests for
these scenarios
Reminder
Added Tests
Ran
npm run convertand committed the changes too