Skip to content

Fix encode only replacing first occurrences #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Fix encode only replacing first occurrences #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ef522
Fix encode only replacing first occurrences
jy14898 Sep 11, 2021
1503222
Update CHANGELOG.md
jy14898 Sep 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Breaking changes:
New features:

Bugfixes:
- Fixed `encode` not replacing all instances of special characters (#254 by @jy14898)

## [v2021-08-25.1](https://github.com/purescript/trypurescript/releases/tag/v2021-08-25.1) - 2021-08-25

Expand Down
10 changes: 5 additions & 5 deletions staging/src/TryPureScript.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,18 @@ module TryPureScript
import Prelude
import Data.Foldable (class Foldable, foldMap)
import Data.String (joinWith)
import Data.String.Common (replace)
import Data.String.Common (replaceAll)
import Data.String.Pattern (Pattern(..), Replacement(..))
import Effect (Effect)

foreign import setInnerHTML :: String -> Effect Unit

encode :: String -> String
encode =
replace (Pattern "<") (Replacement "&lt;")
<<< replace (Pattern ">") (Replacement "&gt;")
<<< replace (Pattern "&") (Replacement "&amp;")
<<< replace (Pattern "\"") (Replacement "&quot;")
replaceAll (Pattern "<") (Replacement "&lt;")
<<< replaceAll (Pattern ">") (Replacement "&gt;")
<<< replaceAll (Pattern "&") (Replacement "&amp;")
<<< replaceAll (Pattern "\"") (Replacement "&quot;")

foreign import withConsoleImpl
:: forall a
Expand Down