-
Notifications
You must be signed in to change notification settings - Fork 168
Refactoring the private API #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 89.46% 89.42% -0.04%
==========================================
Files 50 50
Lines 3550 3538 -12
==========================================
- Hits 3176 3164 -12
Misses 374 374
Continue to review full report at Codecov.
|
8e6d5fd to
579d71a
Compare
TomKemp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Left some comments that don't require changes.
- Also renames the methods for best practices and readability
This PR:
Aims to improve the readability of the private API of the SDK, by simplifying it and bringing it more inline with Swift best practices. This introduces no major breaking changes to the public API, but can be seen as a precursor for the same kind of improvements being made to the public API for a future 10.0.0 release.
Pusherprefix and/or using more descriptive nouns)CryptotypeConstants.APIenum is not exposed publiclydefaultHosttoPusherHostwas made to allow for this change.URLFoundation typepublicandopenaccess level specifiers in Tests