Skip to content

Rename "pc" edition to "java" #26

@ItsDrike

Description

@ItsDrike

Even though in the source minecraft-data repo, the java edition is called "pc" edition, this is misleading and not many people know it under this name. For us, it would make more sense to refer to it as the java edition within the wrapper, for user familiarity and just use pc when loading the data internally within the lib.

This should be as simple as changing the Edition enum and renaming the PC variant to JAVA variant, but leaving "pc" as the value. This would be a breaking change though. We could consider deprecating, but because the lib is still in very early stages, I don't think it's necessary, especially if this is done alongside #23 , which will also be a breaking change without deprecations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: apiRelated to core public API of the projectm: breakingThis introduces backwards compatibility breaking changes to the public APIp: 2 - normalShould be done reasonably soon, but not urgent/blockings: staleHas had no activity for a while (might get closed for inactivity/marked up for grabs soon)t: revisionComplete or partial rewrite of something (code cleanup, performance improvements, etc.)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions