native_proto_caster.h: Add *_with_smart_holder_support_enabled specializations.
#170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/658807442
branch
3 times, most recently
from
ca57662 to
62c190f
Compare
…ializations. The * `copyable_holder_caster_shared_ptr_with_smart_holder_support_enabled` and * `move_only_holder_caster_unique_ptr_with_smart_holder_support_enabled` SFINAE helpers were introduced with pybind/pybind11#5257. They need to be specialized here (`std::false_type`) because native_proto_caster.h has its own specializations for * `copyable_holder_caster<ProtoType, std::shared_ptr<ProtoType>>` and * `move_only_holder_caster<ProtoType, std::unique_ptr<ProtoType>>`. PiperOrigin-RevId: 658867114
copybara-service
bot
force-pushed
the
cl/658807442
branch
from
62c190f to
51fc4ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
native_proto_caster.h: Add
*_with_smart_holder_support_enabledspecializations.The
copyable_holder_caster_shared_ptr_with_smart_holder_support_enabledandmove_only_holder_caster_unique_ptr_with_smart_holder_support_enabledSFINAE helpers were introduced with pybind/pybind11#5257. They need to be specialized here (
std::false_type) because native_proto_caster.h has its own specializations forcopyable_holder_caster<ProtoType, std::shared_ptr<ProtoType>>andmove_only_holder_caster<ProtoType, std::unique_ptr<ProtoType>>.