migrate setup.cfg to pyproject.toml #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
certain tools like |
Contributor
Author
|
I already used dedicated migration tools : setuptools-py2cfg and then ini2toml. Both work very well and I have ported several open-source projects with. There is only one real error left and I am not sure it's directly related to my work. Would you have a look please? |
adehad
requested changes
Jan 29, 2024
Contributor
adehad
left a comment
adehad
left a comment
There was a problem hiding this comment.
yep no issues on the cloud build failure, small re-ordering but otherwise all good.
Thanks
adehad
approved these changes
Mar 25, 2024
Contributor
|
Thanks for the contribution! |
JaviMerino
added a commit
to JaviMerino/nixpkgs
that referenced
this pull request
Feb 10, 2025
7e7963d (python3Packages.jira: 3.8.0 -> 3.9.4, 2025-01-19) update python3Packages.jira to 3.9.4. After that commit, python-jira fails to build: $ nix build -L --impure --expr '(import ./. {}).python3.withPackages(ps: [ ps.jira ])' [...] error: builder for '/nix/store/bfr24lmgw4izl9ixh2sdm794a9kky7w6-python3.12-jira-3.9.4.drv' failed with exit code 1; last 19 log lines: > Sourcing python-remove-tests-dir-hook > Sourcing python-catch-conflicts-hook.sh > Sourcing python-remove-bin-bytecode-hook.sh > Sourcing pypa-build-hook > Using pypaBuildPhase > Sourcing python-runtime-deps-check-hook > Using pythonRuntimeDepsCheckHook > Sourcing pypa-install-hook > Using pypaInstallPhase > Sourcing python-imports-check-hook.sh > Using pythonImportsCheckPhase > Sourcing python-namespaces-hook > Sourcing python-catch-conflicts-hook.sh > Running phase: unpackPhase > unpacking source archive /nix/store/ck51dycsghmkf7449p615crsqdn2xsni-source > source root is source > setting SOURCE_DATE_EPOCH to timestamp 315619200 of file "source/tox.ini" > Running phase: patchPhase > substitute(): ERROR: file 'setup.cfg' does not exist For full logs, run 'nix log /nix/store/bfr24lmgw4izl9ixh2sdm794a9kky7w6-python3.12-jira-3.9.4.drv'. error: 1 dependencies of derivation '/nix/store/i5xib9msa42grs3cwa1ibw0cfdi799f9-python3-3.12.8-env.drv' failed to build The functionality in setup.cfg was moved to pyproject.toml in pycontribs/jira@668562a3f8c7 (migrate `setup.cfg` to `pyproject.toml` (pycontribs/jira#1776), 2024-03-25). Patch pyproject.toml so that python3Packages.jira builds again.
10 tasks
JaviMerino
added a commit
to JaviMerino/nixpkgs
that referenced
this pull request
Feb 17, 2025
7e7963d (python3Packages.jira: 3.8.0 -> 3.9.4, 2025-01-19) update python3Packages.jira to 3.9.4. After that commit, python-jira fails to build: $ nix build -L --impure --expr '(import ./. {}).python3.withPackages(ps: [ ps.jira ])' [...] error: builder for '/nix/store/bfr24lmgw4izl9ixh2sdm794a9kky7w6-python3.12-jira-3.9.4.drv' failed with exit code 1; last 19 log lines: > Sourcing python-remove-tests-dir-hook > Sourcing python-catch-conflicts-hook.sh > Sourcing python-remove-bin-bytecode-hook.sh > Sourcing pypa-build-hook > Using pypaBuildPhase > Sourcing python-runtime-deps-check-hook > Using pythonRuntimeDepsCheckHook > Sourcing pypa-install-hook > Using pypaInstallPhase > Sourcing python-imports-check-hook.sh > Using pythonImportsCheckPhase > Sourcing python-namespaces-hook > Sourcing python-catch-conflicts-hook.sh > Running phase: unpackPhase > unpacking source archive /nix/store/ck51dycsghmkf7449p615crsqdn2xsni-source > source root is source > setting SOURCE_DATE_EPOCH to timestamp 315619200 of file "source/tox.ini" > Running phase: patchPhase > substitute(): ERROR: file 'setup.cfg' does not exist For full logs, run 'nix log /nix/store/bfr24lmgw4izl9ixh2sdm794a9kky7w6-python3.12-jira-3.9.4.drv'. error: 1 dependencies of derivation '/nix/store/i5xib9msa42grs3cwa1ibw0cfdi799f9-python3-3.12.8-env.drv' failed to build The functionality in setup.cfg was moved to pyproject.toml in pycontribs/jira@668562a3f8c7 (migrate `setup.cfg` to `pyproject.toml` (pycontribs/jira#1776), 2024-03-25). Use pytest-cov-stub instead of the `postPatch` hack.
marcin-wozniak-wttech
pushed a commit
to marcin-wozniak-wttech/jira
that referenced
this pull request
Apr 4, 2025
marcin-wozniak-wttech
pushed a commit
to marcin-wozniak-wttech/jira
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a work in progress for now.