Allow users to search issues without retrieving fields #2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible with the current implementation, the service still makes an unnecessary API call to cache fields. This commit resolves that issue by validating the fields cache only when the user explicitly requests fields.
Siddhant791
reviewed
Apr 15, 2025
adehad
approved these changes
Apr 16, 2025
adehad
reviewed
Apr 16, 2025
Comment on lines
+3713
to
+3714
| # this is required only for mypy validation | ||
| fields = [] |
There was a problem hiding this comment.
(non-blocking) in general for these simple comments that don't put us above the line limit, I would push them onto one line, as these comments can get missed and become out of date when not associated with a line of code.
Suggested change
| # this is required only for mypy validation | |
| fields = [] | |
| fields = [] # help mypy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use advanced search instead of #1933
PR allows users to perform a search without specifying fields. While this is already possible with the current implementation, the service still makes an unnecessary API call to cache fields. This PR resolves that issue by validating the fields cache only when the user explicitly requests fields.