Skip to content

double counting bug in gemini yield #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+2 −2
Closed

double counting bug in gemini yield #1711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pydantic_ai_slim/pydantic_ai/models/gemini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,13 +434,13 @@ async def _get_gemini_responses(self) -> AsyncIterator[_GeminiResponse]:
responses_to_yield = gemini_responses[:-1]
for r in responses_to_yield[current_gemini_response_index:]:
current_gemini_response_index += 1
self._usage += _metadata_as_usage(r)
self._usage = _metadata_as_usage(r)
yield r

# Now yield the final response, which should be complete
if gemini_responses:
r = gemini_responses[-1]
self._usage += _metadata_as_usage(r)
self._usage = _metadata_as_usage(r)
yield r

@property
Expand Down
Loading