Adding thinkingpart to otel_events in ModelResponse #2237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtyavrdhn
commented
Jul 17, 2025
Contributor
Author
|
I've clubbed the events together keeping only ToolCallPart separate. |
…/pydantic-ai into thinking_blocks_spans
…hinking_blocks_spans
…/pydantic-ai into thinking_blocks_spans
alexmojaki
reviewed
Jul 22, 2025
…/pydantic-ai into thinking_blocks_spans
alexmojaki
reviewed
Jul 22, 2025
…/pydantic-ai into thinking_blocks_spans
alexmojaki
reviewed
Jul 22, 2025
alexmojaki
approved these changes
Jul 22, 2025
Contributor
alexmojaki
left a comment
alexmojaki
left a comment
There was a problem hiding this comment.
This looks good but it turns out our UI isn't quite ready yet so I think merging this should wait a bit
alexmojaki
reviewed
Jul 23, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2131
Moves from each TextPart being its own event to clubbing all TextParts and ThinkingPart events into one body
Updates the tests based on this new approach