Fix: TypeError in MCPServerSSE due to improper initialization #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tradeqvest
changed the title
Contributor
|
We're experiencing the same issue, and this PR resolves the error |
Collaborator
|
@tradeqvest Thank you Niko! I'll get a release out in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a
TypeErrorthat occurs when usingMCPServerSSEand other HTTP-based MCP servers. The issue stemmed from the_MCPServerHTTPclass constructor, which was not calling the__post_init__method from theMCPServerbase class. This led to_enter_locknot being correctly initialized as anasyncio.Lock.The fix ensures
__post_init__is called within the_MCPServerHTTPconstructor, correcting the initialization sequence.Fixes #2318